search

minimaxir / facebook-page-post-scraper

Data scraper for Facebook Pages, and also code accompanying the blog post How to Scrape Data From Facebook Page Posts for Statistical Analysis
2.12k stars 662 forks source link

Add CODE Cutting off scrape after a certain date. #42

Closed dizwe closed 7 years ago

dizwe commented 7 years ago

I add add since, until that can cut the period that I want to scrape. Because your time is set based on EST time, so I also did.

Somebody don't want to use this function. So if user since=None, until=None, the work works just as you wrote.

minimaxir commented 7 years ago

No longer applicable.

dizwe commented 7 years ago

Does the 'No longer applicable' means either the code does not run properly OR you don't need additional since,until code to your code? If 'No longer applicable' meaning the latter( you don't have to additional since,until code to your code), I just wondering why you commit since, until date parameter not merge my code. I just want to know the specific reason you don't merge my code if you think that since/until parameter is necessary. Somehow thanks for making facebook-scraper!

minimaxir commented 7 years ago

Back then, code changes broke the PR.

The new code I added today avoids a few bugs present in this PR (this PR does not allow the user to set just one of since/until, and this PR checks against None instead of checking against an empty string, which is a usability deviation)

dizwe commented 7 years ago

Thank you for commenting! I will consider about usability when I write the code. :]