minimaxir / facebook-page-post-scraper

Data scraper for Facebook Pages, and also code accompanying the blog post How to Scrape Data From Facebook Page Posts for Statistical Analysis
2.12k stars 662 forks source link

CLI added #60

Closed gabru-md closed 7 years ago

gabru-md commented 7 years ago

With reference to issue #45 CLI has been added to all the Python files. Readme.md has also been updated with the arguments required.

Please see and merge if possible!

BTW: Thanks for creating this script ! <3

minimaxir commented 7 years ago

Seems like a good approach for a CLI but may need a few tweaks for a consistent style:

gabru-md commented 7 years ago

@minimaxir Okay it can be done.

  1. The code will be formatted using autoPEP8.
  2. I did not notice it before, but now i'll call the get_args() inside __name__ == "__main__".
gabru-md commented 7 years ago

I've done the necessary changes but if still something is missing then forgive me XD

gabru-md

gabru-md commented 7 years ago

@minimaxir what happened sir?

minimaxir commented 7 years ago

This PR requires additional testing since it changes how the script is operated, so it may take a little more time to merge. I'll see what I can do today.

gabru-md commented 7 years ago

is the testing done master?

minimaxir commented 7 years ago

Currently busy with other things. No ETA on when this will be merged.

minimaxir commented 7 years ago

Merging this into a CLI branch for the time being. The core functionality is fine, but it will need a lot of fixing up before I merge into Master.