search

minimul / qbo_api

Ruby JSON-only client for QuickBooks Online API v3. Built on top of the Faraday gem.
MIT License
85 stars 46 forks source link

Add attachment read/delete methods #104

Closed franklin-stripe closed 4 years ago

franklin-stripe commented 4 years ago

Fixes #103

franklin-stripe commented 4 years ago

This is having some build errors that should be fixed in https://github.com/minimul/qbo_api/pull/105

minimul commented 4 years ago

Thanks – well done.

Can you run again on the CI with >= 1.10 being passed to the bundler gem dependency?

franklin-stripe commented 4 years ago

@minimul added a commit with the bundler gem dependency and things seem to work

minimul commented 4 years ago

Ok, I took a closer look.

Take out the bump version to 1.8.6 commit and then squash all commits into a single commit with a good description.

Thanks.

franklin-stripe commented 4 years ago

@minimul done!

minimul commented 4 years ago

Thanks again @franklin-stripe – released as 1.8.6