search

minimul / qbo_api

Ruby JSON-only client for QuickBooks Online API v3. Built on top of the Faraday gem.
MIT License
85 stars 45 forks source link

wip: Remove Faraday Middleware #117

Closed bf4 closed 1 year ago

Greyoxide commented 1 year ago

Are there any updates on this? I'd love to use this awesome gem but the Faraday mis-match is messing me up.

bf4 commented 1 year ago

Personally if me I need to run the test suite etc. I just wrote this quickly to show the way and then forgot about it, oops

I think there might also be a behavior change around mime type parsing which may come up.

On Wed, Dec 28, 2022, 2:17 PM Greyoxide @.***> wrote:

Are there any updates on this? I'd love to use this awesome gem but the Faraday mis-match is messing me up.

— Reply to this email directly, view it on GitHub https://github.com/minimul/qbo_api/pull/117#issuecomment-1366866691, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABC4QU3Y6BQ47LHWZU2B7TWPSG27ANCNFSM6AAAAAASU322VA . You are receiving this because you were mentioned.Message ID: @.***>

minimul commented 1 year ago

It is not hitting any pain points for me at the moment but I'll merge in a quality fix and re-release quickly if you all or someone wants to tackle it.

Greyoxide commented 1 year ago

I'd love to help but I know so little about the gem or the faraday_middleware gem, I'm worried I'd break something. If someone wanted to outline specific areas to focus on and what needed to happen, I'd be willing to take a crack at it.

bf4 commented 1 year ago

The change needed is basically this pr. I'm not around to test if the changed are good or not and ci didn't run. But I've replaced all my other faraday json usages in my app which used faraday_middleware with a change like in the pr.

On Thu, Dec 29, 2022, 1:21 PM Greyoxide @.***> wrote:

I'd love to help but I know so little about the gem or the faraday_middleware gem, I'm worried I'd break something. If someone wanted to outline specific areas to focus on and what needed to happen, I'd be willing to take a crack at it.

— Reply to this email directly, view it on GitHub https://github.com/minimul/qbo_api/pull/117#issuecomment-1367506777, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABC4QURJ7KILTY4LS5FJ33WPXJC7ANCNFSM6AAAAAASU322VA . You are receiving this because you were mentioned.Message ID: @.***>

bf4 commented 1 year ago

Superseded by https://github.com/minimul/qbo_api/pull/118