search

minimul / qbo_api

Ruby JSON-only client for QuickBooks Online API v3. Built on top of the Faraday gem.
MIT License
85 stars 46 forks source link

Documentation issue -> api.send_invoice() example #130

Open roboyeti opened 8 months ago

roboyeti commented 8 months ago

RE: api.send_invoice(invoice_id: 1, email_address: 'billy@joe.com') example Problem: 1.> api doesn't match the rest of the examples, probably should be: qbo_api 2.> There is no send_invoice() call, that I or Ruby could find. Looking thru the code, it appears to be .deliver() 3.> Parameters appear to be different as well for solution, see below.

Solution (not documented) The following works for me, following along with the doc example from the start: qbo_api.deliver(:invoice, { entity_id: , params: [ email_address: })

f someone is still active enough around here to merge changes, I can certainly make the doc changes and add a send_invoice, since that would make sense to have as a common action.

minimul commented 8 months ago

Yup, it is .deliver ref: https://github.com/minimul/qbo_api/pull/112/files

Nice catch.

I'll merge the documentation changes.