search

minimul / qbo_api

Ruby JSON-only client for QuickBooks Online API v3. Built on top of the Faraday gem.
MIT License
85 stars 45 forks source link

added get_pdf method #135

Closed Greyoxide closed 1 month ago

Greyoxide commented 3 months ago

Hi this is my first ever pull request so let me know if I've done something wrong.

I've implemented a get_pdfmethod as described in issue number 62. I've also added a test to the test suite which tests this new method against the invoices endpoint. I've also tested the new method against the development mode on my production app by downloading a pdf copy of an invoice, estimate, and purchase order.

In addition to the get_pdf method appended to qbo_api/api_methods.rb, I've also adjusted the response method found in connection.rb. Given that application/json is the default content type, I've added a check to determine if this case is an exception to the default content type.

minimul commented 3 months ago

I will review within the next week.

minimul commented 3 months ago

OK. This looks fine.

Next week, I'm going to test it more thoroughly.

In the meantime, if you could implement my comments.

Thank you.

minimul commented 2 months ago

I'll take a look soon.

minimul commented 1 month ago

I'll be taking a look this week.

minimul commented 1 month ago

Merged and released in 3.0.3.