search

minimul / qbo_api

Ruby JSON-only client for QuickBooks Online API v3. Built on top of the Faraday gem.
MIT License
85 stars 46 forks source link

application/pdf? #62

Closed JohnSmall closed 4 years ago

JohnSmall commented 6 years ago

Using this gem in earnest now. It's really useful and I really appreciate the work you've done on it. I see you've even done a method to get the reports, which is a nice touch.

But I'm missing a method to get invoices as pdf files. I see from the documentation that it's a simple get request with the invoice id, but I have to set the Content Type = 'application/pdf' and there doesn't seem to be an easy way to do that without adding some extra parameters to the method calls.

Any thoughts?

minimul commented 6 years ago

Yeah, a new method would have to be made e.g.

qbo_api.get_pdf(:estimate, 3133)
JohnSmall commented 6 years ago

Ok, I'll do it and send a PR when it's done. It'll be a few days though.

minimul commented 6 years ago

Update: @bf4 is going to be adding this ability soon (see comment near bottom => https://github.com/minimul/qbo_api/pull/67)

bf4 commented 6 years ago

FYI https://github.com/minimul/qbo_api/pull/77

minimul commented 4 years ago

Closing as too much time has lapsed.