search

minimus / simple-ads-manager

Advertisement rotation system for Wordpress with a flexible logic of displaying advertisements.
16 stars 15 forks source link

Gh upstream patch #8

Closed goatherd closed 10 years ago

goatherd commented 10 years ago

remaining patch from: http://wordpress.org/support/topic/deprecation-notice-and-patch-wordpress-38

goatherd commented 10 years ago

Fixed some more backend quirks.

You utilise many boolean tests where all you need is array-key existence. This will work on classic PHP with no debug notices but will cause headaches for developers relying on WP_DEBUG and should be avoided. It may cause maintenance headaches too for people doing proper error logging (which is not too common with WordPress).

It should be advised to activate WP_DEBUG locally and run a few tests (once every couple of releases):

Quick-testing using this patch and recent develop branch I could verify no more notices for non-config pages and nothing major (warning/ error) for backend.