minio / console

Simple UI for MinIO Object Storage :abacus:
https://min.io/docs/minio/linux/index.html
GNU Affero General Public License v3.0
852 stars 282 forks source link

feat(i18n): add internationalization support to web-app #3463

Open lvyueyang opened 3 weeks ago

lvyueyang commented 3 weeks ago

Hello, I hope to continue to promote the internationalization of minio, which is what many people in the community are looking forward to.

I have submitted a PR(https://github.com/minio/console/pull/2443) before, but it was not passed. I think the main reason for the failure is that there were too many file changes involved, and such large-scale changes would make code review very difficult.

So, this time I want to change it. I will briefly talk about my ideas and hope to use a gradual approach to promote internationalization.

  1. Add i18next to the project and use only one file for internationalization as an example (control the file changes within 10 files).

  2. Add the internationalization extraction tool i18next-parser, which can automatically help us maintain the translation directory.

  3. Divide the internationalization of the file into many times, and ensure that the file changes are within 10 each time (only some displayed text is changed to t("text")).

This will not burden your developers' work. You can only use English for development (only t("text") is needed), and the translation work can be handed over to the community.

If you are worried about the quality of the community's translation, I can withdraw the submission of the web-app/public/locals/cn/ directory and let the users of minio provide their own translations or the community maintain a repository of internationalized translation files. In this way, you only need to add internationalization support in the code and do not need to take any responsibility for the translation results.

Well, this is my idea. If you think this method is good, I hope you can merge this PR after consideration. Everyone is really looking forward to minio providing internationalization support. minio does a really good job. We also hope to contribute to the beautiful minio. Thank you.