search

minio / console

Simple UI for MinIO Object Storage :abacus:
https://min.io/docs/minio/linux/index.html
GNU Affero General Public License v3.0
852 stars 282 forks source link

Release v1.7.4 #3472

Open bexsoft opened 1 week ago

donatello commented 1 week ago

Do we merge with the CI failure?

ramondeklein commented 1 week ago

Do we merge with the CI failure?

I don’t think we should. Why do we need a new console release at this time?

bexsoft commented 1 week ago

Do we merge with the CI failure?

Yes, This PDF issue is not a real failure, PDF is rendered correctly in the UI Locally I see an error related to pdf worker library required for this and testcafe. This needs further investigation

bexsoft commented 2 days ago

@bexsoft Did you regenerate the files after rebasing to the latest master? When I run make release, then all generated files are different but that may be caused due to different versions. I do think the build folder should be identical and not depend on whoever runs make release.

For that reason, I am always a fan of letting the CI/CD build the final output instead. Then it's consistent.

Yes, @ramondeklein, all files are updated with the latest master change. we use a release script to generate these files, maybe could be related

feorlen commented 1 day ago

@bexsoft corresponding docs ready to merge https://github.com/minio/docs/pull/1373