search

minio / directpv

Kubernetes CSI driver for Direct Attached Storage :minidisc:
https://directpv.io
GNU Affero General Public License v3.0
596 stars 88 forks source link

v4.0.10 changed the StorageClass parameters preventing upgrade from v4.0.9 #908

Closed suever closed 3 months ago

suever commented 6 months ago

Describe the bug The minor patch release v4.0.10 modified the parameters of the created StorageClass. Because storage classes are immutable, the storage class has to be recreated (but all volumes have to be removed first). This breaks the ability to upgrade from v4.0.9

To Reproduce Install v4.0.9, create PVCs that use DirectPV, attempt an upgrade (in-place or offline) to v4.0.10

Expected behavior The upgrade should succeed

Additional context At the very least there should be some documentation of this breaking change and some suggestions on mitigation. Ideally the semantic versioning should reflect this as well.

Longer-term, changes to the StorageClass probably should not be made and instead a new storage class should be created via DirectPV. Care should also be taken such that the old parameters still work when adjusting the SC parameters as not everyone will be able/willing to migrate for a patch release

balamurugana commented 6 months ago
  1. What is the error you are getting?
  2. Have you tried in-place upgrade by https://github.com/minio/directpv/blob/master/docs/upgrade.md#in-place-upgrade ?
Praveenrajmani commented 3 months ago

Closing this stale issue, please feel free to re-open if you face any issues again.