Minor cleanups. - Githubissues

minio / dsync

A distributed sync package.

Apache License 2.0

400 stars 41 forks source link

Minor cleanups. #36

Closed balamurugana closed 7 years ago

balamurugana commented 7 years ago

Rename Node() to ServerAddr()
Rename rpcPath() to Resource()
Rename SetNodesWithClients() to Init()

fwessels commented 7 years ago

LGTM

krisis commented 7 years ago

@fwessels @balamurugana this is a breaking change. Any application that imports dsync would break if they pulled this change. Was changing names of exported variables that important?

balamurugana commented 7 years ago

@fwessels @balamurugana this is a breaking change. Any application that imports dsync would break if they pulled this change. Was changing names of exported variables that important?

As dsync is a separate library, this change is requested for consumers. Previous names are quite confusing and not intuitive.