search

minio / dsync

A distributed sync package.
Apache License 2.0
400 stars 41 forks source link

Fix all golint issues on dsync #40

Open harshavardhana opened 7 years ago

harshavardhana commented 7 years ago 
$ golint ./...
drwmutex.go:50:6: exported type Granted should have comment or be unexported
drwmutex.go:52:2: struct field lockUid should be lockUID
drwmutex.go:63:6: exported type LockArgs should have comment or be unexported
drwmutex.go:72:1: exported method LockArgs.SetToken should have comment or be unexported
drwmutex.go:76:1: exported method LockArgs.SetTimestamp should have comment or be unexported
drwmutex.go:80:1: exported function NewDRWMutex should have comment or be unexported
drwmutex.go:167:4: var bytesUid should be bytesUID
drwmutex.go:281:9: if block ends with a return statement, so drop this else and outdent its block
dsync.go:36:1: comment on exported function Init should be of the form "Init ..."
chaos/chaos-server.go:31:1: comment on exported const LockMaintenanceLoop should be of the form "LockMaintenanceLoop ..."
chaos/chaos-server.go:38:7: exported const LockCheckValidityInterval should have comment or be unexported
chaos/chaos.go:510:6: exported type RWLocker should have comment or be unexported
chaos/chaos.go:517:6: exported type DRWMutexNoWriterStarvation should have comment or be unexported
chaos/chaos.go:522:1: exported function NewDRWMutexNoWriterStarvation should have comment or be unexported
chaos/chaos.go:529:1: exported method DRWMutexNoWriterStarvation.Lock should have comment or be unexported
chaos/chaos.go:536:1: exported method DRWMutexNoWriterStarvation.Unlock should have comment or be unexported
chaos/chaos.go:540:1: exported method DRWMutexNoWriterStarvation.RLock should have comment or be unexported
chaos/chaos.go:547:1: exported method DRWMutexNoWriterStarvation.RUnlock should have comment or be unexported
chaos/lock-rpc-server.go:30:38: error strings should not be capitalized or end with punctuation or a newline
chaos/net-rpc-client.go:131:1: exported method ReconnectRPCClient.ServerAddr should have comment or be unexported
chaos/net-rpc-client.go:135:1: exported method ReconnectRPCClient.Resource should have comment or be unexported
performance/net-rpc-client.go:131:1: exported method RPCClient.ServerAddr should have comment or be unexported
performance/net-rpc-client.go:135:1: exported method RPCClient.Resource should have comment or be unexported
performance/performance-server.go:28:38: error strings should not be capitalized or end with punctuation or a newline
performance/performance-server.go:30:7: exported const WriteLock should have comment or be unexported
performance/performance-server.go:77:7: exported const ReadLock should have comment or be unexported
harshavardhana commented 7 years ago

Assigning to @deekoder to find a proper assignee

harshavardhana commented 6 years ago

this is still valid and we need to fix.

deekoder commented 6 years ago

assigning it to @fwessels to look into when he has time.

hydeenoble commented 5 years ago

Hello @deekoder, can I pick this up if @fwessels is still a little tied up?

harshavardhana commented 5 years ago

Feel free to send the PR @hydeenoble

fwessels commented 5 years ago

That would be great 👍

hydeenoble commented 5 years ago

Alright, great.