Closed harshavardhana closed 7 years ago
Merging #46 into master will decrease coverage by
0.06%
. The diff coverage is77.61%
.
@@ Coverage Diff @@
## master #46 +/- ##
==========================================
- Coverage 85.71% 85.65% -0.07%
==========================================
Files 2 3 +1
Lines 203 230 +27
==========================================
+ Hits 174 197 +23
- Misses 23 27 +4
Partials 6 6
Impacted Files | Coverage Δ | |
---|---|---|
drwmutex.go | 84.93% <66.66%> (+0.61%) |
:arrow_up: |
retry.go | 82.6% <82.6%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update e444a2e...b9f8bb7. Read the comment docs.
Without these changes running for example:
Leads to minio server reaching OOM and being killed as reported in https://github.com/minio/minio/issues/4139
With this PR running the same example never crashes the server rather also throttles down the request. Especially focussed on
Limit the amount of go-routines.
Also retrying the lock is now based on a more optimal jitter mechanism.
Also changes sendRelease() behavior to be blocking rather than trying multiple attempts in a go-routine over a long period of time.
Passes all the tests