search

minio / dsync

A distributed sync package.
Apache License 2.0
400 stars 41 forks source link

Ability to pass source and id from the client. #52

Closed kannappanr closed 5 years ago

kannappanr commented 5 years ago

Ability to pass source and id of the lock to dsync.

fwessels commented 5 years ago

Do we want to enfore that the id is non-null? (as per https://github.com/minio/dsync/blob/master/dsync-server_test.go#L97)

fwessels commented 5 years ago

We are changing the interface, so we should update the README as well to reflect this.

fwessels commented 5 years ago

LGTM

harshavardhana commented 5 years ago

CI is failing @kannappanr lets move dsync travis to 1.11.x

codecov-io commented 5 years ago

Codecov Report

Merging #52 into master will decrease coverage by 0.42%. The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #52      +/-   ##
==========================================
- Coverage   86.19%   85.77%   -0.43%     
==========================================
  Files           3        3              
  Lines         239      253      +14     
==========================================
+ Hits          206      217      +11     
- Misses         27       29       +2     
- Partials        6        7       +1
Impacted Files Coverage Δ
drwmutex.go 85.41% <90%> (-0.54%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a9254b1...50a5d89. Read the comment docs.