search

minio / kes

Key Managament Server for Object Storage and more
https://min.io/docs/kes/concepts/
GNU Affero General Public License v3.0
460 stars 97 forks source link

Added unit tests for various key stores #363

Closed shtripat closed 1 year ago

shtripat commented 1 year ago

Purpose of this change is to enable testing of various backend key stores like Azure, GCP, HashiCorp Vault etc. The tests use command like flags e.g. aws.config, azure.config to get details to connect to the key store. This is done to make the changes generic and so code remains agnostic to addition of new keystores.

Also this way we are making sure all backend key store integrations work just fine and later when integrated with KES server and client making calls throughKES server, there wont be any surprises.

aead commented 1 year ago

Also, can you squash the commits into one and add a commit message explaining the purpose of this change and why things are done in a certain way - e.g. why we use the config file CLI flag approach etc. @shtripat

shtripat commented 1 year ago

Also, can you squash the commits into one and add a commit message explaining the purpose of this change and why things are done in a certain way - e.g. why we use the config file CLI flag approach etc. @shtripat

Sure. Will do that.