minio / kes

Key Managament Server for Object Storage and more
https://min.io/docs/kes/concepts/
GNU Affero General Public License v3.0
456 stars 95 forks source link

Error: minisign: invalid signature: invalid untrusted comment #372

Closed tsohst closed 1 year ago

tsohst commented 1 year ago

Bug describtion

kes update returns Error: minisign: invalid signature: invalid untrusted comment

Expected behavior

Download and replace the binary

Additional context

I've testet version 2023-05-02T22-48-10Z (newest) and 2023-02-15T14-54-37Z (our current version) and both have the same result.

0 minio2 ~ # ./kes-linux-amd64 --version
kes 2023-05-02T22-48-10Z (commit=1e46c482c170614d9e61f16b50de39cac3593a22)
0 minio2 ~ # ./kes-linux-amd64 update
Downloading KES minisign signature...Error: minisign: invalid signature: invalid untrusted comment
1 minio2 ~ # /usr/local/bin/kes-server/kes --version
kes 2023-02-15T14-54-37Z (commit=8ce403b264e3c6fafb94577dd1c59ae811963e43)
0 minio2 ~ # /usr/local/bin/kes-server/kes update
Downloading KES minisign signature...Error: minisign: invalid signature: invalid untrusted comment

Maybe there is something wrong with the repo?

shtripat commented 1 year ago

@aead looks like latest release is tagged with v0.1.0. Is that correct or need some change?

$ curl -XGET https://api.github.com/repos/minio/kes-go/releases/latest
{
  "url": "https://api.github.com/repos/minio/kes-go/releases/92329369",
  "assets_url": "https://api.github.com/repos/minio/kes-go/releases/92329369/assets",
  "upload_url": "https://uploads.github.com/repos/minio/kes-go/releases/92329369/assets{?name,label}",
  "html_url": "https://github.com/minio/kes-go/releases/tag/v0.1.0",
  "id": 92329369,
  "author": {
    "login": "aead",
    "id": 20368805,
    "node_id": "MDQ6VXNlcjIwMzY4ODA1",
    "avatar_url": "https://avatars.githubusercontent.com/u/20368805?v=4",
    "gravatar_id": "",
    "url": "https://api.github.com/users/aead",
    "html_url": "https://github.com/aead",
    "followers_url": "https://api.github.com/users/aead/followers",
    "following_url": "https://api.github.com/users/aead/following{/other_user}",
    "gists_url": "https://api.github.com/users/aead/gists{/gist_id}",
    "starred_url": "https://api.github.com/users/aead/starred{/owner}{/repo}",
    "subscriptions_url": "https://api.github.com/users/aead/subscriptions",
    "organizations_url": "https://api.github.com/users/aead/orgs",
    "repos_url": "https://api.github.com/users/aead/repos",
    "events_url": "https://api.github.com/users/aead/events{/privacy}",
    "received_events_url": "https://api.github.com/users/aead/received_events",
    "type": "User",
    "site_admin": false
  },
  "node_id": "RE_kwDOI9fFks4FgNWZ",
  "tag_name": "v0.1.0",
  "target_commitish": "main",
  "name": "v0.1.0",
  "draft": false,
  "prerelease": false,
  "created_at": "2023-02-14T10:06:14Z",
  "published_at": "2023-02-14T10:09:34Z",
  "assets": [

  ],
  "tarball_url": "https://api.github.com/repos/minio/kes-go/tarball/v0.1.0",
  "zipball_url": "https://api.github.com/repos/minio/kes-go/zipball/v0.1.0",
  "body": "## What's Changed\r\n* add actions for CI and golangci config by @aead in https://github.com/minio/kes-go/pull/1\r\n\r\n## New Contributors\r\n* @aead made their first contribution in https://github.com/minio/kes-go/pull/1\r\n\r\n**Full Changelog**: https://github.com/minio/kes-go/commits/v0.1.0",
  "mentions_count": 1
}
harshavardhana commented 1 year ago

This is about kes binary @shtripat