search

minio / kes

Key Managament Server for Object Storage and more
https://min.io/docs/kes/concepts/
GNU Affero General Public License v3.0
459 stars 97 forks source link

fix: Avoid crash when approle is not used #421

Closed vadmeste closed 11 months ago

aead commented 11 months ago

@vadmeste Which KES version are you using to trigger this. This should've caught one layer above. However, LGTM

shtripat commented 11 months ago

@vadmeste Which KES version are you using to trigger this. This should've caught one layer above. However, LGTM

Agree, as with latest kes I see that these errors get caught while loading the config file itself. Anyway its good to have nil check added here.

vadmeste commented 11 months ago

@vadmeste Which KES version are you using to trigger this. This should've caught one layer above. However, LGTM

master can reproduce this. I think it is enough if you use kubernetes auth; in that case c.AppRole will be nil