search

minio / kes

Key Managament Server for Object Storage and more
https://min.io/docs/kes/concepts/
GNU Affero General Public License v3.0
456 stars 94 forks source link

fix: Upgrade azserect client for AZURE #430

Closed jiuker closed 3 months ago

jiuker commented 7 months ago

Upgrade azserect client How to test:

export ClientID=UUID
export EndPoint=url
export Secret=secret
export TenantID=tid
export ManagedIdentityClientID=micd
go test github.com/minio/kes/internal/keystore/azure

Once the verification is successful, I remove the redundant code fix https://github.com/minio/kes/issues/261

bh4t commented 7 months ago

Hey @aead can you please review this when you get a chance?

vadmeste commented 7 months ago

@jiuker did you get the chance to test this with Azure ? let me know if you need any help in Azure

jiuker commented 7 months ago

@jiuker did you get the chance to test this with Azure ? let me know if you need any help in Azure

Yeah. Pre commit have test code. I have tested it. @vadmeste

harshavardhana commented 7 months ago

@aead we need to get this merged for a new kes release, so that we can move to a supported SDKs. Can you PTAL ?

bh4t commented 6 months ago

@aead can you please review this?

harshavardhana commented 6 months ago

@aead we need to migrate to new SDK previous one is unmaintained now.. its a security risk.

harshavardhana commented 4 months ago

Checking back again on this @aead let me know if you could look at this PR.

harshavardhana commented 3 months ago

https://github.com/minio/kes/pull/459 supersedes this PR, closing this one.