minio / kes

Key Managament Server for Object Storage and more
https://min.io/docs/kes/concepts/
GNU Affero General Public License v3.0
456 stars 94 forks source link

fix goroutine leak when reloading server config #469

Closed aead closed 2 months ago

aead commented 2 months ago

This commit fixes a goroutine leak that occurs when reloading the server configuration.

During a config reload, the server establishes a 2nd connection to the backend keystore and replaces the existing connection with the newly opened one. The switch is performed atomically (without locking) to not block or abort ongoing requests.

Once the server has replaced the keystore connection, it closes it. Before this commit, the server stopped the in-memory key cache and its GC goroutines. However, it did not close any resources (goroutines/file descriptors) allocated by the replaced keystore. This commit fixes this.

The resource leak can only be observed when reloading the KES server config - i.e. using SIGHUP signals