minio / mc

Unix like utilities for object store
https://min.io/download
GNU Affero General Public License v3.0
2.86k stars 548 forks source link

Add `ldap accesskey create`, update `accesskey list` with new endpoint #4760

Closed taran-p closed 10 months ago

taran-p commented 11 months ago

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers under the terms of the [Apache 2 license] (https://www.apache.org/licenses/LICENSE-2.0). By creating this pull request I represent that I have the right to license the contributions to the project maintainers under the Apache 2 license.

Description

Not ready for review Accompanying minio/minio#18402

Adds mc idp ldap accesskey create, which creates an LDAP access key with desired settings, and can take both short LDAP username or full DN as an input user, or none to create one for the authenticated user.

Adds mc idp ldap accesskey create --login for use in an interactive terminal, which allows a user to input their LDAP username and password and returns a corresponding access key with desired settings.

Changes mc idp ldap accesskey list so it uses new API endpoint, which verifies the user is in LDAP and can take both short username and full DN. Also changes --temp-only to --sts-only and --permanent-only to --svcacct-only to avoid confusion.

Motivation and Context

How to test this PR?

Types of changes

Checklist:

taran-p commented 11 months ago

This looks good to me (pending testing) - is there anything left to be done? if not please mark it as ready for review.

Everything is ready, but it's dependent on the serverside PR that is still being worked on. I can mark it as ready if it makes sense to