All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
There was a validation that said --json is supported only when --airgap is also passed for SUBNET related mc support commands.
Remove this validation to allow --json to be passed even in online mode. In this scenario, print a status JSON after upload to SUBNET.
While at it,
mc support profile currently doesn't support --json properly. fix
it.
Remove --api-key flat from mc support proxy commands as they don't
need to talk to SUBNET.
Motivation and Context
Ensure --json is supported in all scenarios
How to test this PR?
Test mc support diag|perf|profile|inspect
verify that all of them support --json irrespective of whether --airgap is passed
Types of changes
[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Optimization (provides speedup with no functional changes)
[ ] Breaking change (fix or feature that would cause existing functionality to change)
Checklist:
[ ] Fixes a regression (If yes, please add commit-id or PR # here)
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers under the terms of the Apache 2 license. By creating this pull request I represent that I have the right to license the contributions to the project maintainers under the Apache 2 license.
Description
There was a validation that said
--json
is supported only when--airgap
is also passed for SUBNET relatedmc support
commands.Remove this validation to allow
--json
to be passed even in online mode. In this scenario, print a status JSON after upload to SUBNET.While at it,
mc support profile
currently doesn't support--json
properly. fix it.--api-key
flat frommc support proxy
commands as they don't need to talk to SUBNET.Motivation and Context
Ensure
--json
is supported in all scenariosHow to test this PR?
mc support diag|perf|profile|inspect
--json
irrespective of whether--airgap
is passedTypes of changes
Checklist:
commit-id
orPR #
here)