Fix regression that causes `mc idp ldap accesskey create` to error

taran-p commented 5 months ago

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers under the terms of the Apache 2 license. By creating this pull request I represent that I have the right to license the contributions to the project maintainers under the Apache 2 license.

Description

Fix error that causes any mc idp ldap accesskey create without a specified expiration time to fail

Motivation and Context

How to test this PR?

Types of changes

[x] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Optimization (provides speedup with no functional changes)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] Fixes a regression minio/madmin-go#277
[ ] Unit tests added/updated
[ ] Internal documentation updated
[ ] Create a documentation update request here

harshavardhana commented 5 months ago

Fix error that causes any mc idp ldap accesskey create without a specified expiration time to fail

what is the error?

taran-p commented 5 months ago

Error was mc: <ERROR> Unable to add service account. the expiration time should be in the future. The command previously sent the unix epoch time if the expiration time was not defined, but now it just sends a nil pointer.

harshavardhana commented 5 months ago

https://github.com/minio/mc/pull/4939 should address, the code itself was not readable using too many variables to do one thing.

I have restructured things and made it more readable PTAL lets close this PR.

minio / mc