Closed dormanze closed 1 month ago
It seems a bit contrary to the usual design that the parameter is always assumed to be local path and not an alias.
Adding a -o=/tmp/myminio-iam.zip
that allows to override the output path seems more appropriate to me.
It seems a bit contrary to the usual design that the parameter is always assumed to be local path and not an alias.
Adding a
-o=/tmp/myminio-iam.zip
that allows to override the output path seems more appropriate to me.
This is a good idea. I added a new flag. Please review again.
@harshavardhana Please review my pr again.
@dormanze I presume it is a script, but could you please turn off the automatic merge with master? It is very noisy and we need to manually re-run tests every time.
@dormanze I presume it is a script, but could you please turn off the automatic merge with master? It is very noisy and we need to manually re-run tests every time.
My bad, This is not a script, I will look at my unclosed pr while browsing the community, manually trigger an update, sorry to bother you, I will stop this operation.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers under the terms of the Apache 2 license. By creating this pull request I represent that I have the right to license the contributions to the project maintainers under the Apache 2 license.
Description
Motivation and Context
How to test this PR?
Types of changes
Checklist:
commit-id
orPR #
here)