minio / mc

Simple | Fast tool to manage MinIO clusters :cloud:
https://min.io/download
GNU Affero General Public License v3.0
2.84k stars 543 forks source link

alias: `mc alias list` command outputs the alias information specified by MC_CONFIG_ENV_FILE #5028

Closed dormanze closed 3 weeks ago

dormanze commented 1 month ago

The output of the mc alias list command is optimized.

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers under the terms of the Apache 2 license. By creating this pull request I represent that I have the right to license the contributions to the project maintainers under the Apache 2 license.

Description

fix #5015

Motivation and Context

How to test this PR?

echo "MC_HOST_minio-1=https://myAccessKey:mySecretAccessKey@minio-1.minio-headless.kube-system.svc.cluster.local:8989" > /home/paas/mymc.config export MC_CONFIG_ENV_FILE=/home/paas/mymc.config export MC_HOST_backup=https://myAccessKey:mySecretAccessKey@minio-0.minio-headless.kube-system.svc.cluster.local:8989

/home/paas/mc alias list

image

Types of changes

Checklist:

klauspost commented 4 weeks ago

Running lint check cmd/alias-list.go:143: File is not gofumpt-ed (gofumpt)

harshavardhana commented 4 weeks ago

what is optimized in the output? - the title can be better worded.

dormanze commented 4 weeks ago

Running lint check cmd/alias-list.go:143: File is not gofumpt-ed (gofumpt)

Thank you for your reminder. I've optimized it.

dormanze commented 4 weeks ago

what is optimized in the output? - the title can be better worded.

what is optimized in the output? - the title can be better worded.

Thanks for the reminder, I've optimized the title.