Autocompletion of s3 paths not working on fish at all

Kakadus commented 2 weeks ago

Expected behavior

After having mc --autocompletion installed, completing remote s3 paths should be autocompleted.

I know there already exist #3727, but I think this is a different error. If it is really https://github.com/posener/complete, then you should issue a warning when installing autocompletion on fish (because they are broken)

Actual behavior

Only local paths are completed by fish

Steps to reproduce the behavior

install autocompletion mc --autocompletion
mc ls myminio/ + TAB

mc --version

mcli version RELEASE.2024-09-16T17-43-14Z (commit-id=11ebe952ea30e426e564f66e78d178465ae7c432) Runtime: go1.23.1 linux/amd64 Copyright (c) 2015-2024 MinIO, Inc. License GNU AGPLv3 https://www.gnu.org/licenses/agpl-3.0.html

System information

fish, version 3.7.1

harshavardhana commented 2 weeks ago

It is only tested on bash or zsh. Fish is not expected to work or neither we have the bandwidth to address it.

Feel free to send a fix if you can.

Kakadus commented 2 weeks ago

Note that https://github.com/urfave/cli/ (whose (a bit outdated) fork https://github.com/minio/cli) supports fish completions since https://github.com/urfave/cli/pull/848. Maybe updating mino/cli will help?

klauspost commented 2 weeks ago

Feel free to send a PR.

minio / mc