put: Add --disable-multipart to make it easier to use.

llchry commented 1 week ago

put: Add --md5 and --disable-multipart to make it easier to use.

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers under the terms of the Apache 2 license. By creating this pull request I represent that I have the right to license the contributions to the project maintainers under the Apache 2 license.

Description

Add --md5 and --disable-multipart for mc put action

Motivation and Context

Add --md5 and --disable-multipart for mc put action

How to test this PR?

Types of changes

[ ] Bug fix (non-breaking change which fixes an issue)
[x] New feature (non-breaking change which adds functionality)
[ ] Optimization (provides speedup with no functional changes)
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[ ] Fixes a regression (If yes, please add commit-id or PR # here)
[ ] Unit tests added/updated
[ ] Internal documentation updated
[ ] Create a documentation update request here

klauspost commented 1 week ago

@harshavardhana @vadmeste @llchry I suggest we hold off on --md5.

I have added checksums to minio-go. While MD5 isn't a checksum in the same sense, it serves the same purpose. So it seems to me like --checksum=MD5|CRC32|CRC32C|SHA1|SHA256 would be a more sensible parameter from a user perspective?

llchry commented 1 week ago

@harshavardhana @vadmeste @llchry I suggest we hold off on --md5.

I have added checksums to minio-go. While MD5 isn't a checksum in the same sense, it serves the same purpose. So it seems to me like --checksum=MD5|CRC32|CRC32C|SHA1|SHA256 would be a more sensible parameter from a user perspective?

Great，that's exactly what I wanted.

klauspost commented 1 week ago

@llchry Just remove the MD5 part. I will do the checksum stuff, since it is a bit more involved. I will ping you on the PR when ready.

llchry commented 1 week ago

@llchry Just remove the MD5 part. I will do the checksum stuff, since it is a bit more involved. I will ping you on the PR when ready.

it has been removed. thanks

klauspost commented 1 week ago

https://github.com/minio/mc/pull/5043 adds checksums across the deck.

minio / mc