minio / mc

Unix like utilities for object store
https://min.io/download
GNU Affero General Public License v3.0
2.88k stars 550 forks source link

Report errors and better file names for mc support inspect #5062

Closed klauspost closed 1 month ago

klauspost commented 1 month ago

Description

Check the returned stream for errors and show them. Don't upload/keep pointless data

Use the request alias to create a better file name...

Example:

λ mc support inspect play/testbucket/testdat/**
mc: <ERROR> Unable to download file data. GetRawData: No files matched the given pattern.

Previously the error would just be ignored.

λ mc support inspect --airgap play/testbucket/testdata/**
File data successfully downloaded as inspect-play_testbucket_testdata.enc

Previously all files would be called inspect-data.enc, which would just be difficult to distinguish.

How to test this PR?

See above

Types of changes