search

minio / minio-cpp

MinIO C++ Client SDK for Amazon S3 Compatible Cloud Storage
https://minio-cpp.min.io/
Apache License 2.0
136 stars 56 forks source link

Memory deallocation in src/client.cc #103

Closed snarky-snarksson closed 8 months ago

snarky-snarksson commented 9 months ago

In https://github.com/minio/minio-cpp/blob/main/src/client.cc#L695 shouldn't the line be delete []buf; ?

And maybe use std::vector instead?

balamurugana commented 9 months ago

Feel free to send a PR

balamurugana commented 8 months ago

Fixed by https://github.com/minio/minio-cpp/pull/105