The following 2 functional tests needs to be cleaned up:
ListenBucketNotificationAsync_Test2
&
ListenBucketNotificationAsync_Test3
First of all, they are not async methods, so the word Async needs to be removed from the names.
Second, there are unused/unnecessary code that can be cleaned up as it is done in PR #1130 for test ListenBucketNotificationAsync_Test1.
Last, we also need to remove the calls to Task.Delay(N) where the N is the wait time in milliseconds.
At this point, values of N are arbitrarily chosen in our code. Instead, we can make it like a wait loop with a time-out value, where we check the status of the task or object, whatever we are waiting for in each step, and keep checking and waiting until the expected happens.
The following 2 functional tests needs to be cleaned up:
ListenBucketNotificationAsync_Test2&ListenBucketNotificationAsync_Test3First of all, they are not async methods, so the word
Asyncneeds to be removed from the names. Second, there are unused/unnecessary code that can be cleaned up as it is done in PR #1130 for testListenBucketNotificationAsync_Test1.Last, we also need to remove the calls to
Task.Delay(N)where theNis the wait time in milliseconds. At this point, values ofNare arbitrarily chosen in our code. Instead, we can make it like a wait loop with a time-out value, where we check the status of the task or object, whatever we are waiting for in each step, and keep checking and waiting until the expected happens.