ci: bump dependencies; remove node 12 and node 14

minio / minio-js

MinIO Client SDK for Javascript

https://docs.min.io/docs/javascript-client-quickstart-guide.html

Apache License 2.0

928 stars 273 forks source link

ci: bump dependencies; remove node 12 and node 14 #1250

Closed aldy505 closed 4 months ago

aldy505 commented 9 months ago

Bump dependencies on CI to use latest versions
Remove Node 12 and Node 14 tests, as we don't support them anymore. They're not maintained versions either.

On the package.json file, it is defined that the minimum of Node.js version is 16. So it makes sense to drop version 12 and 14.

https://github.com/minio/minio-js/blob/51cf376d29d805e8b2aae02653cf1779817409ad/package.json#L75-L77

trim21 commented 9 months ago

should we also downgrade @types/node to v16？

aldy505 commented 9 months ago

should we also downgrade @types/node to v16？

@trim21 No need, right? We're bundling everything with Babel anyway.

trim21 commented 9 months ago

should we also downgrade @types/node to v16？

@trim21 No need, right? We're bundling everything with Babel anyway.

we didn't bundle anything

aldy505 commented 8 months ago

should we also downgrade @types/node to v16？

@trim21 No need, right? We're bundling everything with Babel anyway.

we didn't bundle anything

I thought Babel was for transpiling to older Nodejs versions, no?

trim21 commented 8 months ago

should we also downgrade @types/node to v16？

@trim21 No need, right? We're bundling everything with Babel anyway.

we didn't bundle anything

I thought Babel was for transpiling to older Nodejs versions, no?

yes, transpiling only

aldy505 commented 8 months ago

should we also downgrade @types/node to v16？

@trim21 No need, right? We're bundling everything with Babel anyway.

we didn't bundle anything

I thought Babel was for transpiling to older Nodejs versions, no?

yes, transpiling only

Ah that should be good enough.

Can I have this reviewed, please? @kaankabalak @prakashsvmx

prakashsvmx commented 8 months ago

the CI still looks for tests on old version of node 12 on windows/ubuntu Test on node 12.x and ubuntu-latest Test on node 12.x and windows-latest

We will check this. @aldy505

aldy505 commented 7 months ago

@prakashsvmx Hi, any updates?

prakashsvmx commented 7 months ago

I think it requires some admin access at the org level , i will check further.

trim21 commented 4 months ago

should also remove file https://github.com/minio/minio-js/blob/master/src/internal/async.ts ....

trim21 commented 4 months ago

also https://github.com/minio/minio-js/blob/114ba7a919223827142ae9f24da3ffe754fbc395/babel-register.js#L22