search

minio / minio-js

MinIO Client SDK for Javascript
https://docs.min.io/docs/javascript-client-quickstart-guide.html
Apache License 2.0
951 stars 277 forks source link

Apply minio/minio-js#1234 #1255

Closed timothyaveni closed 6 months ago

timothyaveni commented 9 months ago

as the original author mentioned, this is untested. i don't love it, but i really would like to have a dev environment that doesn't need 'network_mode': 'host' just so i can use the same hostname for minio internally and on the server...

pharapeti commented 6 months ago

I'd really appreciate it if this change made it in - seems like it's been requested a fair bit since 2019. @prakashsvmx

prakashsvmx commented 6 months ago

We would not be able to accept a solution that is not s3 compliant. Please provide an s3 equivalent or s3 ' SDK's reference for implementation.

timothyaveni commented 6 months ago

oh strange, I don't think I ever explicitly made a PR for this; I was never looking for it to be merged into master, I just put it in my own fork so I could use it in a project (and maybe made a PR against my own master branch?). I guess @pharapeti's comment somehow turned it into a PR against minio:master?

apologies for the repo noise. I still don't know how to use GitHub, apparently!!

pharapeti commented 6 months ago

Hey @timothyaveni, you created this PR - I just added a comment to indicate support for the change :wink: