minio / minio-js

MinIO Client SDK for Javascript
https://docs.min.io/docs/javascript-client-quickstart-guide.html
Apache License 2.0
951 stars 277 forks source link

SSE support for getObject #1263

Closed JohannGit closed 4 months ago

JohannGit commented 8 months ago

Currently minio-js has SSE support for putObject but not for getObject. I had to do a npx patch for my project to support it, but I'll be glad if it's part of the minio-js directly.

This PR is related to very old issues but SSE support for getObject never reached master branch:

This PR brings the ability to give SSE headers to the getObject call via the metaData parameter, the same way putObject does.

JohannGit commented 4 months ago

@prakashsvmx sorry CI were not successful cause I forgot to use prettier. Now it should be all good 👍

JohannGit commented 4 months ago

@prakashsvmx This is good, I fixed the last lint error (import sort)