minio / minio-js

MinIO Client SDK for Javascript
https://docs.min.io/docs/javascript-client-quickstart-guide.html
Apache License 2.0
920 stars 271 forks source link

Return type for `TypedClient.getBucketVersioning()` still incorrect? #1303

Open fflorent opened 2 months ago

fflorent commented 2 months ago

Follow-up of #1296, see comment https://github.com/minio/minio-js/issues/1296#issuecomment-2135726689

The method still may return an empty string when the versioning is disabled on the bucket (that's because the returned <VersioningConfiguration> xml element is empty in such a case).

Otherwise the returned value could be null or undefined, but that may be a breaking change.

I may submit a PR to bring the change if it would be welcome.