search

minio / minio-js

MinIO Client SDK for Javascript
https://docs.min.io/docs/javascript-client-quickstart-guide.html
Apache License 2.0
945 stars 276 forks source link

Discrepancy between docs and TS typings #1320

Open a-babarytskyi opened 3 months ago

a-babarytskyi commented 3 months ago

Hi everyone,

I've encounterd an issue. As I was copying code from examples some of them suggested putting error callback in putObject method as 6th argument. TS gives an error, it says that only 5 arguments are expected. Version 7.1.4 and version 8.0.1 give same error.

API reference https://min.io/docs/minio/linux/developers/javascript/API.html#putObject

Screenshot of TS suggestions:

Screenshot 2024-07-18 at 21 01 01

From what I see in the code, there is no argument either, so probably docs need an update. Is it a correct repo for this issue then?

prakashsvmx commented 3 months ago

We will update the docs. It will happen once the release is done. We will also update the examples. Thank you for reporting.