Add type annotations to xml.py

minio / minio-py

MinIO Client SDK for Python

https://docs.min.io/docs/python-client-quickstart-guide.html

Apache License 2.0

851 stars 325 forks source link

Add type annotations to xml.py #1327

Closed trim21 closed 11 months ago

trim21 commented 11 months ago

ci failed for some unknown reason...

trim21 commented 11 months ago

Duck typing in this PR is incomplete. Please fix accordingly.

Sorry, which class/function are you referring to? IFromXML and IToXML are incomplete?

your review comment didn't attach to any line of files.

balamurugana commented 11 months ago

Duck typing in this PR is incomplete. Please fix accordingly.

Sorry, which class do you mean? IFromXML and IToXML are incomplete?

Code in xml.py

trim21 commented 11 months ago

Duck typing in this PR is incomplete. Please fix accordingly.

Sorry, which class do you mean? IFromXML and IToXML are incomplete?

Code in xml.py

done