search

minio / minio-py

MinIO Client SDK for Python
https://docs.min.io/docs/python-client-quickstart-guide.html
Apache License 2.0
851 stars 325 forks source link

GetBucketLocation API does not require path-style addressing in AWS S3 #1430

Open lentitude2tk opened 3 months ago

lentitude2tk commented 3 months ago

From the AWS S3 API documentation, we can see that the GetBucketLocation API supports virtual style access.Tested locally without any issues.

https://docs.aws.amazon.com/AmazonS3/latest/API/API_GetBucketLocation.html

image

lentitude2tk commented 3 months ago

As GetBucketLocation is deprecated, actually we suppose to use HeadBucket to fetch location instead of GetBucketLocation. I would like to leave it as is ATM.

From the perspective of code referencing hierarchy, almost all interface methods in minio-py are based on the GetBucketLocation method, first querying the region based on the bucket, and then performing secondary operations. Does the deprecated of GetBucketLocation refer to the Minio layer or the AWS side?

https://github.com/minio/minio-py/blob/ffe9045fc8bdb435c02054336c79670ed61704a1/minio/api.py#L437

lentitude2tk commented 3 months ago

HeadBucket also relies on the processing of the self._get_region(bucket_name) method, which itself uses the GetBucketLocation method.