Closed CarterMcClellan closed 7 years ago
@CarterMcClellan looks like shellcheck
is failing, please check
Also, here a document of all tests which I am working towards implementing in mint.
Doc has been updated to reflect updated tests, and removal of event related tests from the TODO agenda
@CarterMcClellan I think it will be better to add the doc as .md
in /run/core/mc
directory
@CarterMcClellan I tried running these changes locally
$ cd mc
$ cat error.log
tput: No value for $TERM and no -T specified
tput: No value for $TERM and no -T specified
curl: (6) Could not resolve host: null
Presigned Upload Test 1 Failure
Error on line 164
jq: error: Could not open file myVar: No such file or directory
Watch Objects Test 1 Error
rm: cannot remove 'myVar': No such file or directory
$ cat output.log
Make Bucket Tests
Entering Make Bucket Test 1
Test Success
Put Object Tests
Entering Put Object Test 1
Entering Put Object Test 2
Test Success
Put Object Multipart Tests
Entering Put Object Multipart Test 1
Entering Put Object Multipart Test 2
Test Success
Mirror Object Tests
Entering Mirror Object Test 1
Test Success
Presigned Upload Object Tests
Entering Share Upload Test 1
Share Upload Test 1 Failure
Presigned Download Object Tests
Entering Presigned Download Object Test 1
Test Success
List Object Tests
Test Success
Cat Object Tests
Test Success
Watch Object Tests
0a1
> ObjectCreated ObjectRemoved
\ No newline at end of file
Watch Objects Test 1 Error
Test Success
Put Object Error Tests
Entering Put Object Error Test 1
Test Success
Make Bucket Object Error Tests
Entering Make Bucket Error Test 1
Test Success
End of tests
1 End of tests
Looks like the logs are not properly reported (see Watch Object Tests
section), also there is text in error.log
can you please check.
@CarterMcClellan i added a comment please take a look.
Prior to the changes mc printed every step to output.log, and logged the tests which were intended to throw errors under error.log.
mc output.log will now provide colorized print of all tests which are executed, all progress bars and extraneous prints have been removed to make output.log more readable. mc error.log will only hold errors if an unintentional error is thrown, the convention followed for logging is that the test which failed will be printed to both output and error.log, inside of error.log a line number which the test failed on will also be provided. Because these tests are being done on mc error logging can be improved with the --debug flag. For mc share upload, and mc share download (the more complicated commands), --debug stack traces are logged under error.log if an error is found.
In accordance with the doc tests for watch (experimental), cat, and ls have all been added to mc.
Fixes #86