cleanup all shell scripts

[nitisht]

looks like ShellCheck is failing @balamurugana can you please fix.

[balamurugana]

@NitishT fixed shellcheck errors. However shellcheck errors shown now are not errors.

[nitisht]

However shellcheck errors shown now are not errors.

Agreed, but we need to follow one style and the linter shellcheck enforces that. We can look at other better linter options if available. Travis still fails.

[harshavardhana]

@NitishT fixed shellcheck errors. However shellcheck errors shown now are not errors.

@balamurugana there is a reasoning behind such a requested change - https://github.com/koalaman/shellcheck/wiki/SC2046

[poornas]

@balamurugana , ran the Dockerfile and Dockerfile.dev - a few more issues:

• pressing Ctrl-C would cancel the run earlier but no longer works. Needs to be resuscitated.

• minio-js fails with Dockerfile.dev but not Dockerfile

  1) functional tests tests for putObject copyObject getObject getPartialObject statObject removeObject should download 100KB string upload and match content:
   Error: content mismatch
    at IncomingMessage.stream.on (test/functional-tests.js:258:16)
    at endReadableNT (_stream_readable.js:974:12)
    at _combinedTickCallback (internal/process/next_tick.js:80:11)
    at process._tickCallback (internal/process/next_tick.js:104:9)
  
  2) functional tests tests for putObject copyObject getObject getPartialObject statObject removeObject should download partial data (100kb of the 6mb file) and match content:
   Error: content mismatch
    at IncomingMessage.stream.on (test/functional-tests.js:313:16)
    at endReadableNT (_stream_readable.js:974:12)
    at _combinedTickCallback (internal/process/next_tick.js:80:11)
    at process._tickCallback (internal/process/next_tick.js:104:9)

[poornas]

might be a good idea to log the sdk version as well in the output/error log.

[balamurugana]

All shellcheck errors and comments are addressed

[balamurugana]

@NitishT

Currently, if a specific SDK tests fails, say minio-go fails, mint stops execution of minio-go tests, moves to the next SDK and starts the tests.

Wanted to clarify if that is the expected behaviour or mint should stop the execution completely on first failure and exit?

This is the current (and correct) behavior.

@poornas

pressing Ctrl-C would cancel the run earlier but no longer works. Needs to be resuscitated.

done

minio-js fails with Dockerfile.dev but not Dockerfile

• Test failures need to be addressed separately in respective SDKs.
• Dockerfile should fail as it clones mint and runs release.sh where release.sh is not available (until this PR merges)

[balamurugana]

travis failure SC2064: Use single quotes, otherwise this expands now rather than when signalled. is not an error. expansion should not occur later.