search

minio / mint

Collection of tests to detect overall correctness of MinIO server.
Apache License 2.0
79 stars 50 forks source link

Update awscli tests to log error messages #153

Closed nitisht closed 6 years ago

nitisht commented 6 years ago

Fixes https://github.com/minio/mint/issues/150

nitisht commented 6 years ago

updated @harshavardhana

nitisht commented 6 years ago
  1. Can we remove the /tmp/multipart file once it is used?

Done

  1. The buckets are not deleted after a failure in the code, since there is no exception, we should try to clean it up.

Added bucket removal logic to error logging cases.

  1. Also, the error field should be used for stack trace alone, so, do you think we should change the error field here to message

Removed few of the cases. But in cases where awscli itself passes (i.e. returns exit code 0) and still the test case fails (say object is downloaded but hash verification fails) I dont see other option, as there is no stack to be published and yet we need to tell in the log what caused the test case to fail.

  1. If AWS returns an error output, they need to be converted to a single line?

done

  1. Should we log the entire awscli command here in the case of function ? Will it be useful to search if the function contains actual endpoint information, bucket names etc? Or can we simplify the function value to just what we are trying to do here, that way it is consistent between endpoint A and endpoint B.

I understand this will be taken care based on the discussion we had during today's call.

kannappanr commented 6 years ago

@balamurugana found one more issue with this log. The duration is a number and it should not have double quotes around the log.

nitisht commented 6 years ago

The duration is a number and it should not have double quotes around the log.

Fixed