search

minio / mint

Collection of tests to detect overall correctness of MinIO server.
Apache License 2.0
79 stars 50 forks source link

Fix mc logging and exit on first failure #159

Closed nitisht closed 6 years ago

nitisht commented 6 years ago

Fixes https://github.com/minio/mint/issues/154

balamurugana commented 6 years ago

PR https://github.com/minio/mint/pull/139 is pulling functional test of mc which is taken care in that.

nitisht commented 6 years ago

@balamurugana we need to release mint soon. Do you think #139 should be merged and be the part of mint first release?

balamurugana commented 6 years ago

@nitisht I am not saying we need to take/wait for https://github.com/minio/mint/pull/139 for the release

nitisht commented 6 years ago

updated the PR @kannappanr

deekoder commented 6 years ago

is travis expected to fail?

kannappanr commented 6 years ago

Shellcheck generates a warning on ls and sort in the following line of code

if  diff -bB <(ls "$MINT_DATA_DIR" | sort) <(./mc ls --json "${SERVER_ALIAS}/${bucket_name}" | jq -r .key | sort) > /dev/null; then

this can be replaced by find like this

if  diff -bB <(find "$MINT_DATA_DIR" -type f -printf "%f\n" | sort) <(./mc ls --json "${SERVER_ALIAS}/${bucket_name}" | jq -r .key | sort) > /dev/null; then
nitisht commented 6 years ago

Updated the PR @kannappanr @deekoder