minio / mint

Collection of tests to detect overall correctness of MinIO server.
Apache License 2.0
79 stars 50 forks source link

add endpoint information at startup. #169

Closed balamurugana closed 6 years ago

nitisht commented 6 years ago

Can we put this info in the log.json, that will be more helpful I think. Something like

{SERVER_ENDPOINT: "", ACCESS_KEY: "", ENABLE_HTTPS: "", SERVER_REGION: "",
MINT_DATA_DIR: "", MINT_MODE: ""}

as the first entry and then the test logs?

balamurugana commented 6 years ago

Adding into log.json would make dynamic json file i.e. the first log entry is not compatible with other known json structure. Is this expected?

nitisht commented 6 years ago

Adding into log.json would make dynamic json file i.e. the first log entry is not compatible with other known json structure.

Yes that is true. But is that a problem? I mean while parsing logs we can start from second entry.

Also, we can add an entry called timestamp like

{SERVER_ENDPOINT: "", ACCESS_KEY: "", ENABLE_HTTPS: "", SERVER_REGION: "",
MINT_DATA_DIR: "", MINT_MODE: "", TEST_RUN_TIME:""}

It will help keep track of multiple mint runs happening in automation.

balamurugana commented 6 years ago

You can skip first line. This needs to be documented. According to JSON it is multi-lined document. This requires more discussion and I would recommend your requirement needs to be fixed in different PR

nitisht commented 6 years ago

This requires more discussion and I would recommend your requirement needs to be fixed in different PR

Okay I will create an issue with the details.