minio / mint

Collection of tests to detect overall correctness of MinIO server.
Apache License 2.0
79 stars 50 forks source link

Remove negative test for invalid object name /2123123\123 #171

Closed nitisht closed 6 years ago

nitisht commented 6 years ago

Minio server doesn't allow object names like /2123123\123, while S3 allows it, so object creation with key /2123123\123 passes with s3 gateway (awscli responds with ETAG in case of success, making mint json log unparseable). Since there is no way to distinguish between Minio Gateway and Server in Mint, this PR updates the test case to allow if the object with key /2123123\123 get uploaded to the Mint test target endpoint.

Fixes: https://github.com/minio/mint/issues/167

vadmeste commented 6 years ago

I am afraid, currently there is no way to identify server and gateway in mint and there is no plan to do this as well AFAIK..so I think we need to ignore such possibilities for now

Why not adding a header in Minio server response to indicate if this is a server or gateway ? The test can make any http call which can have 403 response but Mint will still be able to extract server type.

We already have a Server header by the way, we can probably enhance it.

balamurugana commented 6 years ago

@vadmeste

Why not adding a header in Minio server response to indicate if this is a server or gateway ? The test can make any http call which can have 403 response but Mint will still be able to extract server type.

We already have a Server header by the way, we can probably enhance it.

As per current decision from the discussion happened, all tests should ignore NotImplemented S3 error from the server irrespective of the server type/mode. We do not need to check whether its gateway or not.

IMO checking gateway type is not the right decision because of gateway behaves differently on backend service type e.g. b2 supports READ-ONLY policy not others to bucket level. Such cases gateway may return NotImplemented for cases.

However you feel free to open an issue and bring it for team discussion.