minio / mint

Collection of tests to detect overall correctness of MinIO server.
Apache License 2.0
79 stars 50 forks source link

Inconsistent function signature style in awscli and mc tests #174

Closed harshavardhana closed 6 years ago

harshavardhana commented 6 years ago
PASS    awscli  make_bucket\n   ---> Very different
PASS    awscli  aws --endpoint-url http://10.0.0.13:9000 s3api get-object --bucket awscli-mint-test-bucket-25082 --key datafile-1-MB /tmp/datafile-1-MB\n ---> This
PASS    mc  make_bucket\n   ---> Very different 
PASS    mc  ./mc cp --json target/mc-mint-test-bucket-3272/datafile-1-MB /tmp\n --> This
nitisht commented 6 years ago

I think we should update mc and awscli logs to adhere to logging format, something like this

{
  "args": {  
   bucket: "awscli-mint-test-bucket-25082",
   key: "datafile-1-MB"
},
  "duration": ,
  "function": "get-object",
  "name": "awscli/test_upload_object",
  "status": "PASS"
}
balamurugana commented 6 years ago

awscli/mc test scripts need to adapt/leverage https://github.com/minio/mc/blob/master/functional-tests.sh

harshavardhana commented 6 years ago

is this fixed already @nitisht @balamurugana ?

balamurugana commented 6 years ago

Its not applicable anymore. We can close this issue

harshavardhana commented 6 years ago

Closing.