Test for virtual host style requests

krishnasrinivas commented 6 years ago

https://github.com/minio/minio/pull/5095 should have mint tests. Test can be done like this:

add the following entries in /etc/hosts in docker image
```
127.0.0.1 test.mydomain.com
127.0.0.1 mydomain.com
```

This is needed because if the bucket is test and endpoing is mydomain.com then the client requests will be done on the host test.mydomain.com which should be resolved to localhost (docker container itself)

run awscli tests with the following setting (in addition to path style tests)
```
aws configure set default.s3.addressing_style virtual
```

krishnasrinivas commented 6 years ago

@nitisht run.sh should look like this so that it runs both path and virtual style:

#!/bin/bash
#
#  Mint (C) 2017 Minio, Inc.
#
#  Licensed under the Apache License, Version 2.0 (the "License");
#  you may not use this file except in compliance with the License.
#  You may obtain a copy of the License at
#
#      http://www.apache.org/licenses/LICENSE-2.0
#
#  Unless required by applicable law or agreed to in writing, software
#  distributed under the License is distributed on an "AS IS" BASIS,
#  WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
#  See the License for the specific language governing permissions and
#  limitations under the License.
#

# handle command line arguments
if [ $# -ne 2 ]; then
    echo "usage: run.sh <OUTPUT-LOG-FILE> <ERROR-LOG-FILE>"
    exit -1
fi

output_log_file="$1"
error_log_file="$2"

# configure awscli
aws configure set aws_access_key_id "$ACCESS_KEY"
aws configure set aws_secret_access_key "$SECRET_KEY"
aws configure set default.region "$SERVER_REGION"

# run tests
endpoint="http://$SERVER_ENDPOINT"
if [ "$ENABLE_HTTPS" -eq 1 ]; then
    endpoint="https://$SERVER_ENDPOINT"
fi
./test.sh "$endpoint"  1>>"$output_log_file" 2>"$error_log_file"

aws configure set default.s3.addressing_style virtual
./test.sh "$endpoint"  1>>"$output_log_file" 2>"$error_log_file"

deekoder commented 6 years ago

@nitisht i see a bunch of commits for this issue. SHould this be closed then?

minio / mint

Test for virtual host style requests #213