minio / mint

Collection of tests to detect overall correctness of MinIO server.
Apache License 2.0
78 stars 50 forks source link

Add new mint arg to test virtual host style with awscli #215

Closed nitisht closed 6 years ago

nitisht commented 6 years ago

Fixes https://github.com/minio/mint/issues/213, should be merged after https://github.com/minio/minio/pull/5095

Assumption is either the domain on which Minio server is running is already resolvable by the host that is running Mint

or

we add hosts to the docker container, that can be done like this:

$ sudo docker run -e "SERVER_ENDPOINT=minio.com:9000" -e "ACCESS_KEY=minio" \
-e "SECRET_KEY=minio123" -e "ENABLE_HTTPS=0" -e "ENABLE_VIRTUAL_STYLE=1" \
--net=host --add-host="minio.com:127.0.0.1" \
--add-host="awscli-mint-test-bucket.minio.com:127.0.0.1" minio/mint awscli
nitisht commented 6 years ago

it's better if mint tests both path and virtual style:

Done @krishnasrinivas

nitisht commented 6 years ago

Can you please review?

nitisht commented 6 years ago

can the docs be updated on how this can be tested as well?

Sure will do.

nitisht commented 6 years ago

Updated @harshavardhana

nitisht commented 6 years ago

This is updated and uses dnsmasq now, PTAL

kannappanr commented 6 years ago

ping @nitisht

kannappanr commented 6 years ago

ping @nitisht

nitisht commented 6 years ago

I need to address @balamurugana comments @kannappanr . Will do in the coming week.

kannappanr commented 6 years ago

ping @nitisht

deekoder commented 6 years ago

@nitisht this is becoming a stale PR. PTAL at your earliest convenience.

nitisht commented 6 years ago

Closing this for now, will send fresh PR