search

minio / mint

Collection of tests to detect overall correctness of MinIO server.
Apache License 2.0
78 stars 50 forks source link

allow SDK versions to be configurable #309

Closed wlan0 closed 3 years ago

wlan0 commented 5 years ago

This PR allows the versions of the following SDK versions to be configurable

This is required for gateway tests, since there was a mismatch between the latest version and the lastest available version from this URL https://dl.minio.io/client/mc/release/linux-amd64/mc.${MC_VERSION}

By explicitly allowing the version to be set, we can avoid the above issue.

The existing behavior is maintained if the versions are not explicitly set.

wlan0 commented 5 years ago

@nitisht I originally did this because few of the SDKs did not work while running gateway tests - minio-java would not finish executing. mc build was looking for a non-existent version. This change parametrizes the versions. Other than allowing me to pin the versions to get over above hurdles, this will also enable testing multiple versions of the SDK for a release of minio.

@wlan0 initial vision while developing mint was that if sdk has an issue we fix the sdk and make a release instead of reverting to a working version. So we did not make the version configurable.

IMHO this goes against that initial philosophy. Is there any specific reason to do this ?

I didn’t know about the philosophy. I understand your concern. Essentially, this change enables users to choose a version if they wanted to, and gives them the keys to revert to working version if they so chose, instead of fixing a broken SDK.

Given your concerns, and given that mint tests seem to be going smoothly now, I dont think this PR is needed anymore. I’m happy to close this, any thoughts @nitisht @vadmeste?

harshavardhana commented 5 years ago

We should discuss this again once @wlan0 @nitisht with @abperiasamy - if there are benefits in this approach we can keep the PR for now.

vadmeste commented 5 years ago

This PR doesn't change the old behavior by default, it only does that when we set SDK_VERSION in the environment. I would say this can be useful for us for debugging.

nitisht commented 5 years ago

Moved to blocked, pending discussion with @abperiasamy .