minio / mint

Collection of tests to detect overall correctness of MinIO server.
Apache License 2.0
78 stars 50 forks source link

Revert "support new minio-js repo workflow" #357

Closed harshavardhana closed 1 year ago

harshavardhana commented 1 year ago

Reverts minio/mint#356

github-actions[bot] commented 1 year ago

sh-checker report

To get the full details, please check in the job output.

shellcheck errors ``` 'shellcheck ' returned error 1 finding the following syntactical issues: ---------- In run/core/s3cmd/test.sh line 97: rv="$1" ^-----^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly). In run/core/s3cmd/test.sh line 98: shift ^---^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly). In run/core/s3cmd/test.sh line 100: if [ "$rv" -ne 0 ]; then ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly). ^-------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly). In run/core/s3cmd/test.sh line 101: echo "$@" ^-------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly). In run/core/s3cmd/test.sh line 104: return "$rv" ^----------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly). In run/core/s3cmd/test.sh line 141: cmd=("${S3CMD_CMD[@]}" "$@") ^--------------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly). In run/core/s3cmd/test.sh line 142: "${cmd[@]}" ^---------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly). In run/core/s3cmd/test.sh line 143: rv=$? ^---^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly). In run/core/s3cmd/test.sh line 144: return "$rv" ^----------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly). In run/core/s3cmd/test.sh line 148: expected_checksum="$1" ^--------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly). In run/core/s3cmd/test.sh line 149: shift ^---^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly). In run/core/s3cmd/test.sh line 150: filename="$*" ^-----------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly). In run/core/s3cmd/test.sh line 152: checksum="$(get_md5sum "$filename")" ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly). ^--------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly). In run/core/s3cmd/test.sh line 153: rv=$? ^---^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly). In run/core/s3cmd/test.sh line 154: if [ "$rv" -ne 0 ]; then ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly). ^-------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly). In run/core/s3cmd/test.sh line 155: echo "unable to get md5sum for $filename" ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly). In run/core/s3cmd/test.sh line 156: return "$rv" ^----------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly). In run/core/s3cmd/test.sh line 159: if [ "$checksum" != "$expected_checksum" ]; then ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly). ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly). In run/core/s3cmd/test.sh line 160: echo "$filename: md5sum mismatch" ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly). In run/core/s3cmd/test.sh line 161: return 1 ^------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly). In run/core/s3cmd/test.sh line 164: return 0 ^------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly). In run/core/s3cmd/test.sh line 246: show "${FUNCNAME[0]}" ^-------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly). In run/core/s3cmd/test.sh line 248: start_time=$(get_time) ^--------------------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly). ^------^ SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly). In run/core/s3cmd/test.sh line 249: object_name="s3cmd-test-object-$RANDOM" ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly). In run/core/s3cmd/test.sh line 250: assert_success "$start_time" "${FUNCNAME[0]}" s3cmd_cmd put "${FILE_1_MB}" "s3://${BUCKET_NAME}/${object_name}" ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly). In run/core/s3cmd/test.sh line 251: assert_success "$start_time" "${FUNCNAME[0]}" s3cmd_cmd rm "s3://${BUCKET_NAME}/${object_name}" ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly). In run/core/s3cmd/test.sh line 252: assert_failure "$start_time" "${FUNCNAME[0]}" s3cmd_cmd get "s3://${BUCKET_NAME}/${object_name}" "${object_name}.downloaded" ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly). In run/core/s3cmd/test.sh line 253: assert_success "$start_time" "${FUNCNAME[0]}" rm -f "${object_name}.downloaded" ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly). In run/core/s3cmd/test.sh line 255: log_success "$start_time" "${FUNCNAME[0]}" ^-- SC2317 (info): Command appears to be unreachable. Check usage (or ignore if invoked indirectly). For more information: https://www.shellcheck.net/wiki/SC2317 -- Command appears to be unreachable... ---------- You can address the above issues in one of three ways: 1. Manually correct the issue in the offending shell script; 2. Disable specific issues by adding the comment: # shellcheck disable=NNNN above the line that contains the issue, where NNNN is the error code; 3. Add '-e NNNN' to the SHELLCHECK_OPTS setting in your .yml action file. ```
shfmt errors ``` 'shfmt -s' found no issues. ```
trim21 commented 1 year ago

should I re-open #356 ?

harshavardhana commented 1 year ago

should I re-open #356 ?

yes please @trim21