search

minio / operator

Simple Kubernetes Operator for MinIO clusters :computer:
https://min.io/docs/minio/kubernetes/upstream/index.html
GNU Affero General Public License v3.0
1.22k stars 455 forks source link

Remove inheritance of some labels #1230

Open aivanov-citc opened 2 years ago

aivanov-citc commented 2 years ago

Hi! We use the Flux GitOps system to deliver the configuration to the cluster. The Flux marks its controlled resources with labels. Only those resources that are in the cluster configuration repository should be monitored.

In the case of minio, these are custom tenant resources, but not statefulsets generated by the operator.

Please add the ability to exclude labels when inheriting from a tenant in a statefulset, for example, using a regular expression, as implemented in the kafka operator

containers:
  - name: strimzi-cluster-operator
    env:
      - name: STRIMZI_LABELS_EXCLUSION_PATTERN
        value: "^kustomize.toolkit.fluxcd.*"
stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed after 21 days if no further activity occurs. Thank you for your contributions.

pjuarezd commented 1 year ago

I am looking at a similar case in strimzi operator for the STRIMZI_LABELS_EXCLUSION_PATTERN https://github.com/strimzi/strimzi-kafka-operator/issues/5242 to understand better what the issue is here.

Are you having a restart of the tenant pods/statefulsets @aivanov-citc? Why you want to prevent the labels propagation?

I am interested on bring to the light which kind of situations could happen if we just propagate the labels, if any.