minio / operator

Simple Kubernetes Operator for MinIO clusters :computer:
https://min.io/docs/minio/kubernetes/upstream/index.html
GNU Affero General Public License v3.0
1.19k stars 449 forks source link

Charts should be prefixed with an identifier #1806

Open carpenterm opened 11 months ago

carpenterm commented 11 months ago

Is your feature request related to a problem? Please describe. The fact the chart is called "operator" is confusing as when you upload it to a repository with a bunch of other charts you have no idea what it is. Same for the "tenant" chart.

Describe the solution you'd like The charts should be prefixed with an identifier e.g. "minio-operator" and "minio-tenant"

Describe alternatives you've considered Hacky renaming of Chart.yaml and folders after downloading which need reapplying on every release and are error prone.

Additional context None

jdonzallaz commented 7 months ago

Hi,

I would add that this also cause conflicts making installing charts dependencies with the same name impossible.

Because the name "operator" is so generic and also used by others (e.g. redpanda), it causes errors on installation: Error: can't get a valid version for repositories operator. Try changing the version constraint in Chart.yaml].

Note: It should also be noted that Helm developers are not willing to fix the underlying cause (see issue).

cesnietor commented 3 months ago

@cniackz could you please take a look at this one and verify if it'd make sense to add the prefix and not cause issues with existing deployments? 🙏

ramondeklein commented 2 months ago

When you add a Helm repository, then you typicall add it like this:

helm repo add minio https://operator.min.io

So, the name of the repository will be called minio. Then when you install it, you run

helm install minio-operator minio/operator --namespace minio-operator --create-namespace

So the actual chart is referenced using minio/operator that references the operator chart in the https://operator.min.io repository. Also the name of the installed instance can be named by the user, so I don't understand the actual problem. I don't see a real issue here.

We can change the Helm charts, but that would render all old documentation, blogs, StackOverflow answers useless. I don't see a good reason why to do this.